View Issue Details

IDProjectCategoryView StatusLast Update
0013107ScribusOS-Win32public2016-11-04 00:18
Reporterbubu Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.1svn 
Target Version1.5.2Fixed in Version1.5.2.svn 
Summary0013107: Wrong language on document closing dialogue: Save - Close without Saving - Cancel
DescriptionA) Finnish words instead of Hungarian in Scribus 1.5.0 on Windows
Instead of Hungarian there are Finnish words on document closing dialogue. See the 1st attachment. The 3 buttons display Finnish words. Other words are OK.

B) Finnish "Shift" word instead of Hungarian in Scribus 1.5.0 on Windows
Instead of Hungarian there is a Finnish "Shift" words in File > Edit menu. See the 2nd attachment. The word "Vaihto" is Finnish (Hungarian==English: Ctrl+Shift+A).

C) Similar to 1st case. On Ubuntu (Scribus friends PPA) the document closing dialogue displays buttons in English. See the 3th attachment.

- The Hungarian .ts file is OK, translations is OK.
- I can't find "Close without Saving" string in translationdummy.cpp. Is this string missing from translation source?
Steps To ReproduceA)
1. Download and install Scribus 1.5.0 on Windows
2. Start Scribus with Hungarian locale.
3. Create a new document
4. Apply a change
5. Go to: File > Close (Fájl > Bezárás)

B)
1. Download and install Scribus 1.5.0 on Windows
2. Start Scribus with Hungarian locale.
3. Create a new document
4. Go to: File > Edit (Fájl > Szerkesztés)

C)
1. Start Scribus 1.5.1 on Ubuntu with Hungarian locale.
3. Create a new document
4. Apply a change
5. Go to: File > Close (Fájl > Bezárás)
TagsQt5.6, upstream
PatchNo

Relationships

related to 0012742 closedcbradney Save/Discard/Cancel should be translatable on document closing (QMessageBox translation) 
has duplicate 0013750 closedjghali German options instead of English 
has duplicate 0013799 closedjghali Button Text in German when Language is set to English 
has duplicate 0013853 closed language issue 
child of 0013860 closedKunda translation dependence from Qt project 

Activities

bubu

2015-06-02 22:19

reporter  

1st Close.jpg (18,686 bytes)   
1st Close.jpg (18,686 bytes)   

bubu

2015-06-02 22:19

reporter  

2nd Edit.jpg (21,882 bytes)   
2nd Edit.jpg (21,882 bytes)   

bubu

2015-06-02 22:19

reporter  

3th Close.jpg (25,731 bytes)   
3th Close.jpg (25,731 bytes)   

bubu

2015-06-02 22:22

reporter   ~0035311

Similar bugreport: 0012742

Kunda

2015-06-30 17:14

updater   ~0035583

Last edited: 2015-06-30 17:20

I've tested all on OSX:
1st case: All the buttons are in english (see OSX-dialog)

2nd case: problem not there

3rd case: all buttons are in english (see OSX-dialog)

I also checked the pending Hungarian Translations (there are 83 left untranslated) and none of them correspond to the buttons in case 1 and 3. So I suppose this is related to 0012742 ??

FYI
It's easy to check this by starting Scribus from command line with flags:
prompt$ Scribus -l hu

Kunda

2015-06-30 17:14

updater  

OSX-Dialog.png (27,888 bytes)   
OSX-Dialog.png (27,888 bytes)   

Kunda

2015-06-30 17:15

updater  

OSX-Dialog-case2.png (79,508 bytes)   
OSX-Dialog-case2.png (79,508 bytes)   

Kunda

2015-06-30 17:21

updater   ~0035584

Perhaps the patch from 0012742 needs to be implemented for other languages ?

bubu

2015-06-30 23:00

reporter   ~0035596

Summary:
- Translation bug A) and B) is Windows only bug.
- Bug C) is a system independent problem.

Kunda

2015-07-16 23:46

updater   ~0035814

Setting this to Windows Category even though part of the report is system independent.

bubu

2016-02-16 20:59

reporter  

window.jpg (11,734 bytes)   
window.jpg (11,734 bytes)   

bubu

2016-02-16 21:03

reporter   ~0038795

Last edited: 2016-02-16 21:09

Bug still present on Scribus 1.5.1 Windows (64): Hungarian + Hebrew (Israel) buttons (reported: Kornél Pércsy)

jghali

2016-02-18 00:13

administrator   ~0038820

I just respined the 1.5.1 Windows installers in order to fix QTBUG-48946 : https://bugreports.qt.io/browse/QTBUG-48946. Please test how that improves this issue.

bubu

2016-02-18 07:41

reporter   ~0038823

Thanks jghali! Reported (Kornél Pércsy) wrote: "It's better :-). Now we can read... Now in Hungarian UI there are English buttons: Save, Discard, Cancel."(Windows 7 64bit) So, it's better, but still not as expected.

jghali

2016-02-18 08:21

administrator   ~0038824

Most strings in Qt Hungarian translation are tagged as obsolete. So if you want improvements on that matter, it seems Qt projects needs you!

bubu

2016-02-18 09:19

reporter   ~0038825

Hm... jghali, do you mean this project? http://l10n-files.qt.io/l10n-files/ Or where to find the job?
Which version should be translated?
- 5.5 qtbase (HU: 0%)
- 5.6 qt (HU: 94%)
- or 5.4 ???

jghali

2016-02-18 09:41

administrator   ~0038827

Qt translations are also available from git. See: http://code.qt.io/cgit/qt/qttranslations.git/

For any details related to Qt project processes, you'll have to contact them directly, unfortunately I cannot provide any.

>> Which version should be translated?
Currently 5.6 seems a good choice. For our case both qt and qtbase translations files should be considered. qtbase is at 0% for HU currently.

Kunda

2016-03-25 13:22

updater   ~0039408

Hey bubu, looks like this was fixed in Qt5.6 as per the upstream ticket: https://bugreports.qt.io/browse/QTBUG-48946
Can you test this please?

PeterBenedek

2016-03-25 19:37

developer   ~0039427

Last edited: 2016-03-25 19:39

Tested Linux Mint 17.3; r21117; Qt5.6.0 RC; Language: HU

Not work: jpg file icon 3th Close.jpg (CloseWindow.png)

PeterBenedek

2016-03-25 19:39

developer  

CloseWindow.png (13,659 bytes)   
CloseWindow.png (13,659 bytes)   

cbradney

2016-03-25 19:56

administrator   ~0039428

@PeterBenedek: that string is not in Scribus anymore, if that is the only issue, its a translation issue and this one can be closed.

PeterBenedek

2016-03-26 08:17

developer   ~0039437

Me good other.

"its a translation issue"
"Close without Saving": language file not included! I checked Transifex.

bubu what do you say?

cbradney

2016-03-26 09:06

administrator   ~0039440

"Close without saving" does not existing within Scribus source code. The translation files need updating by the translator.

Kunda

2016-03-27 11:37

updater   ~0039451

craig, little confused. Do we need to bump the translation files again then?

bubu

2016-03-27 20:11

reporter   ~0039461

Craig, thanks for your suggestions.

We checked Qt translations. 1) I made Qt 5.6 translation for qtbase_hu.ts and @PeterBenedek checked it on Mint replacing /opt/Qt5.6.0/5.6/gcc_64/translations/qtbase_hu.qm. But the problem isn't resolved. 2) After that I checked Qt 5.4 on my Ubuntu. I noticed that the original /usr/share/qt5/translations/qtbase_hu.qm file contains these strings with Hungarian translation: "Close without Saving" -> „Bezárás mentés nélkül”... So, there is no untranslated strings.

Hm, are you sure, you're right? Or what should I do?

jghali

2016-03-28 00:07

administrator   ~0039464

There is apparently some real problems with Qt hu translation. In French this works perfectly.

First look at the difference between qt_fr.ts (or qt_de.ts or qt_it.ts) and qt_hu.ts. The difference explains that any qtbase_hu.ts modifications will not be taken into account. So you should first adapt qt_hu.ts to use same structure.

Secondly : qtbase Hungarian translation completely miss the QPlatformTheme and QGnomeTheme contexts which are used to translate corresponding string. In the hungarian translation the "Close without Saving" string is placed in the QDialogButtonBox context, which means Qt will not find proper context for translation. So it seems qtbase_hu.ts file needs to be updated by running lupdate on Qt code before even starting updating Qt hu translation.

So basically to update hu translation:
1) update qt_hu.ts to use same structure as qt_fr.ts
2) run lupdate on Qt code to update qtbase_hu.ts : you'll have to find someone else than me here to give you an exact way to do so
3) translate qtbase_hu.ts
4) generate qtbase_hu.qm
5) generate qt_hu.qm

Kunda

2016-11-04 00:18

updater   ~0042314

See https://wiki.scribus.net/canvas/Official:Translation_Howto#Translating_Qt_framework

Issue History

Date Modified Username Field Change
2015-06-02 22:19 bubu New Issue
2015-06-02 22:19 bubu File Added: 1st Close.jpg
2015-06-02 22:19 bubu File Added: 2nd Edit.jpg
2015-06-02 22:19 bubu File Added: 3th Close.jpg
2015-06-02 22:22 bubu Note Added: 0035311
2015-06-30 17:14 Kunda Note Added: 0035583
2015-06-30 17:14 Kunda File Added: OSX-Dialog.png
2015-06-30 17:15 Kunda File Added: OSX-Dialog-case2.png
2015-06-30 17:20 Kunda Note Edited: 0035583
2015-06-30 17:20 Kunda Relationship added related to 0012742
2015-06-30 17:21 Kunda Note Added: 0035584
2015-06-30 17:21 Kunda Status new => confirmed
2015-06-30 23:00 bubu Note Added: 0035596
2015-07-16 23:46 Kunda Note Added: 0035814
2015-07-16 23:46 Kunda Category Translation => OS-Win32
2015-07-17 02:39 Kunda Product Version => 1.5.1svn
2015-07-17 02:39 Kunda Target Version => 1.6 milestone
2016-02-16 20:59 bubu File Added: window.jpg
2016-02-16 21:03 bubu Note Added: 0038795
2016-02-16 21:09 bubu Note Edited: 0038795
2016-02-17 09:27 jghali Relationship added has duplicate 0013750
2016-02-18 00:13 jghali Note Added: 0038820
2016-02-18 07:41 bubu Note Added: 0038823
2016-02-18 08:21 jghali Note Added: 0038824
2016-02-18 09:19 bubu Note Added: 0038825
2016-02-18 09:41 jghali Note Added: 0038827
2016-03-08 07:39 jghali Relationship added has duplicate 0013799
2016-03-25 13:15 Kunda Relationship added related to 0013853
2016-03-25 13:21 Kunda Tag Attached: upstream
2016-03-25 13:22 Kunda Note Added: 0039408
2016-03-25 13:23 Kunda Relationship replaced has duplicate 0013853
2016-03-25 13:25 Kunda Tag Attached: Qt5.6
2016-03-25 19:37 PeterBenedek Note Added: 0039427
2016-03-25 19:37 PeterBenedek Note Edited: 0039427
2016-03-25 19:39 PeterBenedek File Added: CloseWindow.png
2016-03-25 19:39 PeterBenedek Note Edited: 0039427
2016-03-25 19:56 cbradney Note Added: 0039428
2016-03-26 08:17 PeterBenedek Note Added: 0039437
2016-03-26 09:06 cbradney Note Added: 0039440
2016-03-26 09:06 cbradney Status confirmed => resolved
2016-03-26 09:06 cbradney Resolution open => fixed
2016-03-26 09:06 cbradney Assigned To => cbradney
2016-03-27 11:37 Kunda Note Added: 0039451
2016-03-27 11:38 Kunda Fixed in Version => 1.5.2.svn
2016-03-27 11:38 Kunda Target Version 1.6 milestone => 1.5.2
2016-03-27 20:11 bubu Note Added: 0039461
2016-03-27 21:29 Kunda Status resolved => feedback
2016-03-27 21:29 Kunda Resolution fixed => reopened
2016-03-28 00:07 jghali Note Added: 0039464
2016-03-28 00:07 jghali Status feedback => resolved
2016-03-28 00:07 jghali Resolution reopened => fixed
2016-05-15 22:53 cbradney Status resolved => closed
2016-11-04 00:17 Kunda Relationship added child of 0013860
2016-11-04 00:18 Kunda Note Added: 0042314