|
|
To update numbering, one has to use "Extra > Update document" option. Maybe the need could detected and the update automated ? Some changes are allready automatically done when editing a numbered list. Sometimes also, scribus detects that the number should be changed after some edit, but scribus doesnt do the update : a '?' is used to temporarily replace the number. I think scribus should call the update instead of replacing with '?'. |
|
|
This bug is just about not having to run Update Document manually.. this was obviously missed in the code when updating styles. |
|
|
I'm working on it =) |
|
|
as JLuc said , it turns out that when click update the text frame doesn't update document and numbers so I called m_doc->updateNumbers(true); m_doc->updateMarks(true); m_doc->regionsChanged()->update(QRect()); in the function: updateTextFrame() to update every things I don't know why scribus use "?" then replace it with "@" , and " Default Paragraph Style" is the same as " no Style " , because when I wrote any text and I didn't choose any style , it always choose the "Default Paragraph Style " . |
|
|
issue13487.patch (468 bytes) |
|
|
various answers : - marks update has allready been recently improved in http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=20528 Are you sure its required to add a one more call to updateMark ? - as for updating numbered lists, it seems improved, but it still takes several/some sort of actions for a numbered list to get updated after deleting a line. Dont you meet that behaviour ? - as for ? : testing the numbered list feature shows that it appears in the canvas display when scribus first creates a new numbered paragraph inside an existing list. I'm not sure why it's not displayed immediately as a number. That can/should possibly be improved. - I guess the @ is used for the story editor view ? - I dont think "Default Paragraph Style" is the same as "no Style", execpt when your frame has a default paragraph style set to "Default Paragraph Style"; but how is this related to this issue ? |
|
|
It would be nice when, instead of displaying a ? when adding a line, a call to m_doc->updateNumbers(true); would enable to display the correct number. + it would be nice when deleting a numbered line would immediately call m_doc->updateNumbers(true); so the numbering is correctly adapted. + it would be perfect when m_doc->updateNumbers(true); is only called when strictly required. That's because the CPU cost could be high on big document, and calling it too often when not necessary could lead to slow scribus. So first detect that it really should be called (have we suppressed a numbered paragraph ? have we added a to-be-numbered paragraph) before calling it. |
|
|
I dont think "Default Paragraph Style" is the same as "no Style", execpt when your frame has a default paragraph style set to "Default Paragraph Style"; but how is this related to this issue ? it's not related to this issue. I have noticed that when I changed paragraph effects for "Default Paragraph Style" to numbering effects , and I wrote any things in story editor with out chosen any style , it takes the default style . see the attached image I think that I will change from "no style" to the "Default Paragraph Style" . |
|
|
I'll try to find where is the best place to call m_doc->updateNumbers(true); thanks for your replay :) |
|
|
Screenshot from 2015-11-11 12:25:30.png (196,311 bytes) |
|
|
any progress on this anood ? |
|
|
Numerated-lists.gif (92,275 bytes) |
|
|
I cannot reproduce this issue with 1.5.4.svn (22063). Anyone can confirm? |
|
|
Tested: Linux Mint 18.1; r22072 Outside the style = work well Inside the style = not work :-( - Make new paragraph style (NumList) - Paragraph Effect -- Enabled Numbered List - Make new TextBox - Apply NumList style in the TextBox - Press: Enter - Enter - Enter etc. - Appear: ? -- Comment: If now apply "Export - Save as PDF" then, in the PDF document appear Instead of numbers: ? - Extras - Update Document (The list is displayed) - You delete some numbers. The list is broken (original problem). :-( |
|
|
This issue should be retested against recent 1.5.6.svn build (at least r23535). |
|
|
@jghali here is test result : - when applying "numbered list" style localy, number is immediately computed and displayed and updated when one of the line is deleted - when defining a paragraph style that is number-listed and applying it to a set of paragraphs, a '?' appears in place of the number. It requires "Extra>Update document" to compute the numbers and replace the ?. And then, deleting one of the lines doesnt update the following numbers. Hmm but not so recent : Version de Scribus 1.5.6.svn 06 Novembre 2019. Too old ? |
|
|
>> Hmm but not so recent : Version de Scribus 1.5.6.svn 06 Novembre 2019. Too old ? Definitely too old. You must have at least build dated from March 31st 2020 to perform the test. |
|
|
Okk YES it's fixed with 31 march build : deleting a numbered line in a list updates all numbers (even when property comes from a named style) Great !! (not tested in real document editing but in short test document). |
|
|
Thanks for testing. I'm resolving this issue then. |
|
|
Fix confirmed! |
- Anonymous
