View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0013814ScribusNLSpublic2016-03-15 10:582016-03-22 23:49
ReporterFahad Assigned Tojghali  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.2.svn 
Fixed in Version1.5.2.svn 
Summary0013814: Main Window layout should be RTL when Arabic translation selected
DescriptionRight now when you select Arabic or any RTL user interface or your locale not LTR, the main window keep LTR layout. Please see the attached screenshot. It should be RTL too.

I have attached patch fix this problem.
Steps To Reproduceset LANG to LANG=ar_OM.UTF-8 or choose Arabic in language interface in preferences
TagsHOST-Oman
PatchYes

Relationships

related to 0013839 new RTL: Main Window layout formatting is off 
related to 0006017 closedjghali when loading hebrew translation, ui (menus) should be justified to the right 

Activities

Fahad

2016-03-15 10:58

developer  

scribus-arabic.jpg (67,871 bytes)   
scribus-arabic.jpg (67,871 bytes)   

Fahad

2016-03-15 10:59

developer  

layout_dir.diff (606 bytes)    

diff --git a/scribus/scribus.cpp b/scribus/scribus.cpp
--- a/scribus/scribus.cpp
+++ b/scribus/scribus.cpp
@@ -319,7 +319,7 @@
 	{
 		qApp->setStyleSheet(QString(stylesheet));
 	}
-
+	qApp->setLayoutDirection(QLocale(ScCore->getGuiLanguage()).textDirection());
 	previewDinUse = false;
 	printDinUse = false;
 	internalCopy = false;
@@ -8413,6 +8413,7 @@
 	m_prefsManager->languageChange();
 	CommonStrings::languageChange();
 	LanguageManager::instance()->languageChange();
+	qApp->setLayoutDirection(QLocale(ScCore->getGuiLanguage()).textDirection());
 	//Update actions
 	if (actionManager!=NULL)
 	{
layout_dir.diff (606 bytes)   

Fahad

2016-03-15 11:03

developer  

scribus-arabic-after-patch.jpg (61,739 bytes)   
scribus-arabic-after-patch.jpg (61,739 bytes)   

Kunda

2016-03-15 22:28

updater   ~0039205

Cool!

jghali

2016-03-15 22:41

administrator   ~0039206

Patch applied, thanks!

Kunda

2016-03-16 04:28

updater   ~0039209

Uploaded a screenshot of how Preferences now look like in RTL mode

Kunda

2016-03-16 04:29

updater  

Screenshot 2016-03-15 23.27.53.png (118,796 bytes)   
Screenshot 2016-03-15 23.27.53.png (118,796 bytes)   

Kunda

2016-03-16 13:25

updater  

new-document.png (103,270 bytes)   
new-document.png (103,270 bytes)   

Kunda

2016-03-16 18:29

updater   ~0039215

also updated how New Document menu looks like
Is there a way to ifdef RTL the UI ?

Kunda

2016-03-22 15:46

updater   ~0039339

Ok.. made a new ticket for formatting in RTL layouts in pref menus 0013839

jghali applied Fahad's patch in r21087
Thanks!

Issue History

Date Modified Username Field Change
2016-03-15 10:58 Fahad New Issue
2016-03-15 10:58 Fahad File Added: scribus-arabic.jpg
2016-03-15 10:59 Fahad File Added: layout_dir.diff
2016-03-15 11:00 Fahad Tag Attached: HOST-Oman
2016-03-15 11:03 Fahad File Added: scribus-arabic-after-patch.jpg
2016-03-15 22:28 Kunda Note Added: 0039205
2016-03-15 22:41 jghali Note Added: 0039206
2016-03-15 22:41 jghali Status new => resolved
2016-03-15 22:41 jghali Fixed in Version => 1.5.2.svn
2016-03-15 22:41 jghali Resolution open => fixed
2016-03-15 22:41 jghali Assigned To => jghali
2016-03-16 04:28 Kunda Note Added: 0039209
2016-03-16 04:29 Kunda File Added: Screenshot 2016-03-15 23.27.53.png
2016-03-16 13:25 Kunda File Added: new-document.png
2016-03-16 18:29 Kunda Note Added: 0039215
2016-03-22 15:42 Kunda Issue cloned: 0013839
2016-03-22 15:42 Kunda Relationship added related to 0013839
2016-03-22 15:46 Kunda Note Added: 0039339
2016-03-22 15:46 Kunda Status resolved => closed
2016-03-22 15:48 Kunda Category General => NLS
2016-03-22 23:49 Kunda Relationship added related to 0006017