View Issue Details

IDProjectCategoryView StatusLast Update
0002576ScribusUser Interfacepublic2016-12-06 15:24
Reporterchristoph_s Assigned To 
PrioritynormalSeverityfeatureReproducibilityalways
Status acknowledgedResolutionopen 
PlatformanyOSanyOS Versionany
Product Version1.3 
Target VersionFuture Release - Low PriorityFixed in Version 
Summary0002576: Add a GUI to create user dictionaries for hyphenation and short words (and spellchecking)
DescriptionNote: this is closely related to 0001108!

It would be useful to have a GUI for user defined hyphenation settings (stored in the sla file or externally?), short words and, as soon as it is available, spellchecking.

I know, some might say this is too close to a word processor, but at least hyphenation and short words are important typography features, and this is one of the things that really count in a DTP software.

I also know, that I can already edit the respective files in an editor, but this is not what most DTP people are used to.
TagsNo tags attached.
PatchNo

Relationships

related to 0001108 assignedavox Let user specify hyphenation exceptions 
related to 0000011 closedcbradney Add Spellcheck functionality to Story Editor 
related to 0003289 assignedsubik adopt the typo spaces into Short Words 
related to 0003911 closedavox Enable "forced" hyphenation 
related to 0004572 new Hyphenation styles (mockup included) 
related to 0004676 acknowledged feature to mark words as "do not hyphenate" 
child of 0003828 acknowledged Metabug: Hyphenation 

Activities

ringerc

2005-09-17 03:18

reporter   ~0006614

This seems reasonable enough. I'm not sure it needs to be a direct part of Scribus, though, as we pretty much use OO.o hyphenation files. Maybe there's an OO.o hyphenation editor available?

As for short words, I really don't know. Seems reasonable enough, just a matter of someone whipping up the tool I guess. I'd suggest doing it as a plugin that could also be run as a stand-alone application.

subik

2005-09-19 15:33

manager   ~0006644

you can edit custom short words in 1.3x version.

christoph_s

2005-09-23 21:40

administrator   ~0006688

>>I'm not sure it needs to be a direct part of Scribus, though, as we pretty much use OO.o hyphenation files. Maybe there's an OO.o hyphenation editor available?

The problem I see here is that scribus may become too dependent on OO.o. As scribus is intended to run natively under Win32 and OS/X too, it is quite likely that OO.o will not be installed on the majority of machines running these OSes

I must admit, however, that the idea of a separate editor (probably as universal tool for short words, hyphenation, spelling + whatever needs to be editable that way in the future), which can also be compiled as plugin, seems quite intriguing to me.

A solution might be something like OO.o's user dictionaries: xml files containing short words, hyphenation exceptions etc.

mhanski

2005-09-27 08:48

developer   ~0006777

> you can edit custom short words in 1.3x version.

Petr, "Edit>Edit system configuration" launches a text editor as the current user, which is useless in this case, since you cannot save the system wide conf file as a simple user. Could you make it launch the text editor as root?

subik

2005-09-27 14:42

manager   ~0006785

I'm rewritting it into Preferences/plugins dialog. It will use something like kcontrol's superuser mode (e.g. at Font configuration etc.). I'm not sure in one thing - how is it portable (win/mac).

ringerc

2005-09-27 15:03

reporter   ~0006786

mhanski: Noooooo! Please no!

The right answer, IMO, is to *copy* the default config to the user's .scribus/ directory, then edit it there. If they want to make the changes apply globally, they can replace the system-wide file with it using standard administration tools.

The less code that ever runs as root, the better. In particular, an app launching an editor as root using a setuid binary is the absolute height of insanity. Try this, using sudo instead of a setuid binary just for this example. If you don't have su, use "su -c" instead:

$ sudo vim /tmp/unimportant_test_file

now, type:

:!sh

and enjoy your new root shell. Exit that with ^D and type:

:e /etc/shadow

where you could replace the root password hash with whatever you felt like.

There are editors with 'restricted' modes, etc, but they're just not good enough. In general, if you launch any app that's not designed from the ground up for single-task secure simple operation as root, you've just given full root access to the user you launched it for.

Even if you just call out to sudo or "su -c" to get root, so the user needs root priveleges anyway, it's just not a good idea to have general GUI apps playing around with root priveleged processes. It's just a bad plan.

If you want a way to globally configure these settings without replacing files from RPM/DEB packages, then the way to do that is to have a search path. That goes for prefs, too. For example, you might search:

$HOME/.scribus/shortwords.$LANG
/etc/scribus/shortwords.$LANG
$PREFIX/share/misc/shortwords.$LANG

For now, though, I suggest just copying the file into the users's .scribus on first use of short-words, then always using it from there. Search paths can be worried about later.

mhanski

2005-09-27 15:24

developer   ~0006787

Well, I'm overwhelmed :) Petr, simply removing the useless "Edit>Edit system configuration" menu entry will do either for the time being, since asking an user for a root password and, in case he knows it, launching an editor as root could pose such a danger.

<quote>
For now, though, I suggest just copying the file into the users's .scribus on first use of short-words, then always using it from there. Search paths can be worried about later.
</quote>

This sounds very plausible to me.

christoph_s

2005-09-27 17:15

administrator   ~0006788

IMHO, the best solution would be to have a copy of the system wide rc file in the user's .scribus directory by default. That way, most users wouldn't even have to think about copying any file anywhere, because they are not familiar with these things. Everything should be as easy as possible.

cbradney

2005-09-27 18:06

administrator   ~0006789

I'd really wonder if this is more a failing of the initial files. IE, how many day to day DTP users actually want to edit this stuff? I'd hazard a guess at bugger all to none. Put a more complete set in the install directories and perhaps thats enough. I'm not against a nice GUI editor for this purpose, but perhaps its an answer to a second issue rather than the first.

subik

2005-09-27 18:49

manager   ~0006791

wait a few hours. I'm working on it.

2005-10-03 20:31

 

short_words_prefs.png (41,988 bytes)
short_words_prefs.png (41,988 bytes)

mhanski

2005-10-03 20:38

developer   ~0006892

Hi Petr, I like the way you've solved the issue with the Short Words preferences.

This remark is not meant for the upcoming 1.3.1 release: Could you add a few words of description to your Short Words prefs dialog (see my attached screen shot). I think it's not obvious enough for new users, what this plug-in is meant for and how to edit the config file.

christoph_s

2005-10-03 20:48

administrator   ~0006893

Hi Maciej,

there is a desription of Short Words in the help files. As for the rest, I agree with you.

mhanski

2005-10-03 21:09

developer   ~0006894

Hi Christoph, I know of the existance of the Short Words help file, but in this case I mean only a short description, sth like "A configurable plug in for inserting non-breaking spaces to prevent unwelcome linewraps" or sth like that in real English, not mine:)

Below the conf file window, I would like to have a clear info, that this config file is editable, because on first sight it wasn't obvious even to me, that this is not only a preview window. Two sentences like "Edit this custom file to replace the system wide configuration. Place a space before or behind a short word to indicate, where the non breaking space should be inserted" will be more than enough, perhaps one of our native speakers could put it even shorter.

christoph_s

2005-10-03 21:27

administrator   ~0006896

Hi Maciej,

agree with you 100 %.

Petr,

would it be possible to have the file uneditable by default and add an "edit" button? A tool tip could be assigned to this button, explaining the function exactly as Maciej suggested. This would also prevent inadvertent editing of the file.

christoph_s

2005-10-04 18:38

administrator   ~0006904

Petr,

I just compiled 1.3.1. The GUI gives the impression that a normal user can edit the system preferences. Is that true? If so, this should be changed as soon as possible, for the reasons mentioned by Craig.

subik

2005-10-04 18:55

manager   ~0006906

Christoph, you can be stoic in this case. User cannot modify any system-wide settings. When he saves(applies) the changes, everything will be saved into ~/.scribus/ directory.
Of course there are missing some illustrative strings (Maciej proposed something above), so I'll create it ASAP. Be patient, please, I've got new job and all is quite hectic for me these days ;)

cbradney

2007-01-04 12:37

administrator   ~0014488

I wouldn't bother with this for 1.3.4. Its only introducing more things to test.

subik

2007-01-04 13:03

manager   ~0014490

Craig, I take it as own as it's related to the "short words" reimplementation planned somewhere between 1.3.5 and 1.3.6

wfzimmerman

2011-08-23 14:48

reporter   ~0026772

compatibility with hyphenation dictionaries from other tools (e.g. Word) would be helpful, especially the ability to import user customizations from those tools.

Kunda

2016-12-06 15:24

manager   ~0042723

unassigning subik and changing to 'acknowledged' + assigning to Future Release - Low Priority

Issue History

Date Modified Username Field Change
2005-09-17 00:01 christoph_s New Issue
2005-09-17 03:18 ringerc Note Added: 0006614
2005-09-17 03:18 ringerc Status new => acknowledged
2005-09-17 03:18 ringerc Category - => User Interface
2005-09-19 15:33 subik Note Added: 0006644
2005-09-19 15:51 mhanski Relationship added related to 0001108
2005-09-23 21:40 christoph_s Note Added: 0006688
2005-09-27 08:48 mhanski Note Added: 0006777
2005-09-27 14:42 subik Note Added: 0006785
2005-09-27 15:03 ringerc Note Added: 0006786
2005-09-27 15:24 mhanski Note Added: 0006787
2005-09-27 17:15 christoph_s Note Added: 0006788
2005-09-27 18:06 cbradney Note Added: 0006789
2005-09-27 18:49 subik Note Added: 0006791
2005-10-03 20:31 mhanski File Added: short_words_prefs.png
2005-10-03 20:38 mhanski Note Added: 0006892
2005-10-03 20:48 christoph_s Note Added: 0006893
2005-10-03 21:09 mhanski Note Added: 0006894
2005-10-03 21:27 christoph_s Note Added: 0006896
2005-10-04 18:38 christoph_s Note Added: 0006904
2005-10-04 18:55 subik Note Added: 0006906
2006-04-14 13:59 mhanski Relationship added related to 0000011
2006-04-14 14:03 mhanski Priority normal => high
2006-04-14 14:03 mhanski OS => any
2006-04-14 14:03 mhanski OS Version => any
2006-04-14 14:03 mhanski Platform => any
2006-04-14 14:03 mhanski Product Version 1.3.1cvs => 1.3
2006-05-16 21:48 christoph_s Relationship added child of 0003828
2006-06-13 01:56 christoph_s Relationship added related to 0003911
2006-11-21 14:51 christoph_s Relationship added related to 0004572
2007-01-04 10:40 subik Status acknowledged => assigned
2007-01-04 10:40 subik Assigned To => subik
2007-01-04 10:41 subik Relationship added related to 0003289
2007-01-04 12:37 cbradney Note Added: 0014488
2007-01-04 13:03 subik Note Added: 0014490
2007-02-17 00:49 christoph_s Relationship added related to 0004676
2011-08-23 14:48 wfzimmerman Note Added: 0026772
2016-12-06 15:24 Kunda Assigned To subik =>
2016-12-06 15:24 Kunda Priority high => normal
2016-12-06 15:24 Kunda Status assigned => acknowledged
2016-12-06 15:24 Kunda Target Version => Future Release - Low Priority
2016-12-06 15:24 Kunda Description Updated View Revisions
2016-12-06 15:24 Kunda Patch => No
2016-12-06 15:24 Kunda Note Added: 0042723